T3 Trade — Fork Review Report

3.1 Metrics trust the data archive blindly P3

Owner: Trading logic review (WP4)

If the market-data archiver goes down mid-session (or starts mid-day) without logging a gap, calculations like session VWAP and the 24h change figure silently compute over whatever bars exist — a 3-bar "session VWAP" would be served at full confidence. The module's own rule is "absence is an answer, never a number," but the guard only rejects holes the archiver itself recorded.

Reference: apps/server/src/trading/archive/derived.ts lines 17–21 (header contract), 231–250 (refuseOnGap), 540–588 (vwap_distance); digest in TradingMarketArchive.ts.

3.2 Unnamed market data is assumed to be ETH P3

Owner: Trading logic review (WP4)

A data delivery that does not name which coin it is for gets evaluated as ETH. This is documented and safe today (all current subscriptions name their coin), but if a coin-less subscription is ever added, Bitcoin bars would silently evaluate ETH watches.

Reference: apps/server/src/trading/WatchEvaluator.ts lines 60, 1160 (DEFAULT_MARKET="ETH").

3.3 Derived watches can run one bar behind P3

Owner: Trading logic review (WP4)

The archiver lags the live WebSocket feed by up to about 60 seconds, so a watch computed from closed bars may exclude the most recently closed bar. This is documented and accepted behavior — named here so it is on record, not treated as a defect.

Reference: apps/server/src/trading/WatchEvaluator.ts lines 1092–1098 (evaluateDerivedDelivery); plan 38 §3.5 comment.

3.4 Price freshness rests on the gateway, not a local check P3

Owner: Trading logic review (WP4)

When deciding whether a price reading is fresh enough to act on, the evaluator relies on the data gateway's freshness windows and a 2-second sweep rather than checking a timestamp itself. A correctness question worth one look someday, not urgent at alpha.

Reference: apps/server/src/trading/WatchEvaluator.ts lines 381, 459–477.

3.5 Compiled Python bytecode is committed P3

Owner: Platform review (WP2)

A .pyc file is tracked in git alongside its source; it will silently drift out of sync the next time the source is edited. Fix is a one-liner: git rm --cached plus a __pycache__/ ignore rule.

Reference: scripts/wake-payload-replay/__pycache__/attribute.cpython-314.pyc (10,967 bytes, tracked — confirmed via git ls-files).

3.6 Chart drag-strips announce the wrong interaction model P3

Owner: UI review (WP3)

The grab-strips for dragging a stop or target level on the price chart are marked with role="slider" but cannot be focused with a keyboard and have no minimum/maximum values or arrow-key handling — the only way to adjust a level is pointer drag. Either drop the role and expose the drag another way, or implement the keyboard behavior the role promises.

Reference: MissionPriceChart.tsx lines 1176–1180 (role="slider", tabIndex={-1}, no aria-valuemin/max, pointer handlers only).

3.7 A code comment understates when the chart is live P3

Owner: UI review (WP3)

A library comment says the chart is only enabled while a position is open ("a flat mission puts nothing on the wire"), but the panel intentionally enables it during planning too ("Planning draws candles too"). The panel behavior is correct and intentional; the comment is stale and should be corrected. No code change needed.

Reference: lib/tradingMarketChartState.ts lines 113–114 vs MissionLivePanel.tsx lines 460, 466, 479–481.

4.1 Generated reports are committed to git Recommendation

Owner: Platform review (WP2)

artifacts/reports holds 26 generated HTML analysis files (+27,206 lines, ~1.3 MB) in version control. Harmless at alpha scale, but it adds merge noise to every upstream sync. Consider moving to artifact storage or a docs folder with a retention rule.

4.2 Mac app is ad-hoc signed, not notarized Context

Owner: Platform review (WP2)

Intentional alpha state: the desktop builds are ad-hoc signed and the install script removes macOS's quarantine flag so they open. Notarization is pending a paid Developer ID. Well documented in the scripts themselves; not a code bug.

4.3 Nightly releases are disabled on the fork Context

Owner: Platform review (WP2)

The release workflow disables nightlies because signing and publishing secrets are absent. Intentional — noted so nobody chases a "broken" nightly later.

4.4 Marketing legal pages were deleted Context

Owner: UI review (WP3)

Privacy-policy, terms-of-service, security-policy, and legal pages were removed with no replacement or redirect, so those URLs return 404. Confirmed as intentional pre-release state by the owner — recorded as context, not a finding. Reinstate before any public release.